ARQ-2231 The JUnit 5 container does not work with manual mode tests #583
Conversation
|
@jamezp any chance your tests in the other PR can be easily adapted to test this? |
It's definitely my plan to add manual mode tests. I'm not sure I'll be able to get to that until next week though. |
|
@jamezp @starksm64 So given all the changes that went into the JUnit 5 extension we are effectively functionally same as the changes proposed by @petrberan in #544 so kudos to him for seeing and doing this first! What I we are still missing is: (1) I am still not sure why we need duplicate before and after notifications (if this was explained somewhere please re-share this and ideally add a note to this class as to why for future reference) and (2) we still need to have this covered by tests - we have a test attached to the Jira which needs to be transformed and added to ARQ testsuite (I believe @jamezp will be looking at this given he is the original autor and reporter). |
|
@rhusar IIRC during my testing they were both needed. It had something to do with when events are fired and needing different contexts for different events. I am working on some tests in #581. I've only got two so far, but hopefully can get some more this week. Right now it's a single in-container test and a manual mode test. I'd like to add some tests which use If anyone has any other tests they think would be useful, please let me know. |
Restoring the fix for https://issues.redhat.com/browse/ARQ-2231 which was inadvertently reverted along restoring the BeforeEachCallback, AfterEachCallback callbacks which turned out to be necessary in some cases. The reproducer attached to ARQ-2231 passes now.