Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable snapshots from jboss.snapshots.repo.url #593

Closed
wants to merge 2 commits into from

Conversation

starksm64
Copy link
Member

Short description of what this resolves:

We need to enable snapshots from jboss.snapshots.repo.url since the integration-tests relies on a snapshot build of arquillian-core

Changes proposed in this pull request:

Add allow-snapshots profile which is activeByDefault

Enable snapshots from jboss.snapshots.repo.url
@starksm64 starksm64 requested a review from jamezp July 9, 2024 18:02
@starksm64
Copy link
Member Author

Ok, I had a misunderstanding of how the integration-test module is being run. The snaphsot build is done before the tests, so why aren't these jobs seeing the build? Even with this change they don't see the snapshot from the jboss nexus repo in the CI environment.

@starksm64
Copy link
Member Author

Ok, no, running ./mvnw -V clean install -U -B -fae '-Pwildfly' '-T1' '-Pintegration-tests' is not building the current release snapshot, so we do need to pull that in, so why doesn't the reference to the activeByDefault allow-snapshots profile work? If I explicitly enable -Pallow-snapshots on the command line it works.

@starksm64
Copy link
Member Author

This really is not the correct solution either as the snapshot build has no relationship to the PR contents. We need to be using the snapshot build from one of the ci.yml steps.

@starksm64 starksm64 marked this pull request as draft July 9, 2024 18:56
@jamezp
Copy link
Collaborator

jamezp commented Jul 9, 2024

@starksm64 #594 should fix this. I had to remove the usage of the version.org.jboss.arquillian properties in the integration tests which just made it easier to override. https://issues.apache.org/jira/browse/MRELEASE-913 is an open issue to resolve that.

Anyway, the root of the problem was the integration-tests module was not included with the release profile so the versions didn't get updated by the maven-release-plugin.

@starksm64
Copy link
Member Author

Ok, closing

@starksm64 starksm64 closed this Jul 10, 2024
@starksm64 starksm64 deleted the starksm64-patch-1 branch September 6, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants