-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(#199): migrate from devshift registry to quay.io #218
Open
hemanik
wants to merge
10
commits into
arquillian:master
Choose a base branch
from
hemanik:migration-to-quay
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
7598cb2
chore: migrate from devshift registry to quay.io
hemanik 2d0e4b0
chore: rename prefix value from QUAY to IMG_REPO.
hemanik ee6328c
fix: DOCKER_REPO value and image names.
hemanik 3c4eefa
chore: rename DOCKER_REPO to IMG_REPO.
hemanik d29bd18
fix: env variables for centos ci.
hemanik e2ba1fa
Merge branch 'master' into migration-to-quay
MatousJobanek 2dabe34
merges upstream master.
hemanik 7d0fa3e
fix: update IMG_REPO value.
hemanik 70fd76d
Merge branch 'migration-to-quay' of https://github.com/hemanik/ike-pr…
hemanik 50b2085
fix: IMG_REPO for local deployment.
hemanik File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
FROM prod.registry.devshift.net/osio-prod/base/pcp-tools:latest | ||
FROM quay.io/openshiftio/rhel-base-pcp-tools:latest | ||
|
||
LABEL maintainer="Devtools <[email protected]>" | ||
LABEL maintainer="Devtools-test <[email protected]>" | ||
|
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest using
IMG_REPO
prefix instead ofQUAY
. This will then have a proper meaning for any repo we use.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the idea for
IMG_REPO
but it's difficult forQUAY_USERNAME
andQUAY_PASSWORD
. Note that this come directly from credentials in CICO, so if we want to rename them, we should do it in these scripts.