Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#165): TestVerifier is executed only in Java files #186

Merged
merged 1 commit into from
Sep 22, 2017

Conversation

lordofthejars
Copy link
Member

Short description of what this resolves:

TestVerifier is executed only in Java files

Changes proposed in this pull request:

  • TestVerifier methods return false if given path is not a Java file

Fixes #165

@bartoszmajsak
Copy link
Member

Should we make it a class for the time being?

@lordofthejars
Copy link
Member Author

Probably when we rewrite everything this would be a class, but for this release I would leave as is

@bartoszmajsak
Copy link
Member

But now we have interface with default methods which effectively makes it a class...

@lordofthejars
Copy link
Member Author

Well actually some tests are implementing this interface for testing purposes, so changing to class requires also a rewrite of the tests. Also if next week we work on rewriting this part, would means change the tests again so it is like in one week do the same task twice.

@bartoszmajsak
Copy link
Member

How long the "reimplementation" will take?

@lordofthejars
Copy link
Member Author

No idea, it depends on how far we want to go. Maybe two days between designing reimplementing and testing

@bartoszmajsak
Copy link
Member

Ok, let's open an issue describing our findings for refactoring and refer to #165 so we can have a trace of ongoing effort. Can you take care of it?

@bartoszmajsak bartoszmajsak merged commit 9b76193 into arquillian:master Sep 22, 2017
@lordofthejars
Copy link
Member Author

This issue is just a workaround, the final solution should be implemented as described in #187

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Affected strategy analyze .class files when target dir not ignored
2 participants