Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor session #13

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Refactor session #13

wants to merge 3 commits into from

Conversation

arshamalh
Copy link
Owner

In the previous version, we stored all the containers and images in the session, that made our lists stale and could cause inconsistency between the real list of images and the one we have, that was also complex and hard to understand what the list is actually used for and we had a mechanism for updating it, I changed the session in a way that we only need to store the current item for cases we need it (remove and rename), in these cases also we don't rely on session but we rely on callback query data attach to the buttons (we also double check we session, but the can be removed), for listing containers and images we call the docker daemon every time but that will not be expensive.

Other refactors are for styling, variable naming and some other little changes.

@arshamalh
Copy link
Owner Author

I'm still not satisfied with the way we implemented session, but we got closer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant