Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laravel 11 Support #320

Merged
merged 4 commits into from
Mar 16, 2024
Merged

Laravel 11 Support #320

merged 4 commits into from
Mar 16, 2024

Conversation

poldixd
Copy link
Contributor

@poldixd poldixd commented Mar 5, 2024

Q A
Is bugfix?
New feature? ✔️
Breaks BC?
Tests pass? ✔️
Fixed issues

This pull request adds Laravel 11 support.

@poldixd poldixd marked this pull request as ready for review March 5, 2024 12:30
@Rattone
Copy link

Rattone commented Mar 5, 2024

The last PR was merged almost a year ago...
@J-Brk is this package still maintained?

@J-Brk J-Brk self-requested a review March 5, 2024 23:29
@J-Brk
Copy link
Collaborator

J-Brk commented Mar 5, 2024

The last PR was merged almost a year ago...
@J-Brk is this package still maintained?

The package is still maintained and very stable. Thank you for contributing!

@J-Brk
Copy link
Collaborator

J-Brk commented Mar 5, 2024

Seems the tests have failed, can you add the exclude for the older PHP versions?

@poldixd
Copy link
Contributor Author

poldixd commented Mar 7, 2024

I dropped PHP and Laravel versions which are end of life.

https://endoflife.date/php
https://endoflife.date/laravel

I'm not sure if I can drop phpspec/phpspec:~5.1.1 as well.

@rickgoemans
Copy link

Any news on this PR? Looking forward to upgrading my application(s) to Laravel 11 but this one is holding me back.

@poldixd
Copy link
Contributor Author

poldixd commented Mar 13, 2024

I'm waiting for a review from @J-Brk :-(

Drop verbose on phpunit since it's no longer supported
@J-Brk
Copy link
Collaborator

J-Brk commented Mar 13, 2024

Sorry for the lack of response & thanks for tagging me as reminder! The changes look good to me but seems we are still failing some tests... Do you have time to quickly fix the the phpunit config? If not I will try to adjust it myself in a few hours

@poldixd
Copy link
Contributor Author

poldixd commented Mar 13, 2024

Unfortunately, I won't be able to make it today. Tomorrow I could have a look at the problem.

@poldixd
Copy link
Contributor Author

poldixd commented Mar 13, 2024

@J-Brk my local tests are now passes. Maybe you can approve my changes.

PHPUnit 10.5.13 by Sebastian Bergmann and contributors.

Runtime:       PHP 8.3.3
Configuration: /Users/nils/Packages/poldixd/seotools/phpunit.xml.dist

................................................................. 65 / 83 ( 78%)
..................                                                83 / 83 (100%)

Time: 00:00.182, Memory: 26.00 MB

OK (83 tests, 103 assertions)

@Rattone Rattone mentioned this pull request Mar 14, 2024
@rickgoemans
Copy link

@J-Brk Is there anything you could tell to when this will be merged/released?

@poldixd
Copy link
Contributor Author

poldixd commented Mar 16, 2024

You can use temporary my repo for this package:

composer.json

{
    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/poldixd/seotools.git"
        }
    ]
}

and then composer require artesaos/seotools

@J-Brk
Copy link
Collaborator

J-Brk commented Mar 16, 2024

Thanks for jumping in @emtudo. I still wanted to do some more checks to make sure it works well but due to time restrains haven't been able to unfortunately.

To prevent others from having to wait to use this, can you quickly release it as new version?

@emtudo
Copy link
Member

emtudo commented Mar 16, 2024

ok @J-Brk I was going to wait for you since you started, but since you asked.

@emtudo emtudo merged commit f87e43a into artesaos:master Mar 16, 2024
6 checks passed
@emtudo
Copy link
Member

emtudo commented Mar 16, 2024

New version released!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants