Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use custom logger if configured, fallback to Rails.logger/STDOUT only if not #78

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dziemian007
Copy link

According to docs, you can set custom logger for APNs

APN.logger = Logger.new(File.join(Rails.root, 'log', 'apn_sender.log'))

But it's overwritten by Rails.logger (and it's cool beacause heroku deploys won't work otherwise, as discussed here #56). The drawback is that you cannot specify custom logger any more. So this patch should add usage of defined one, and fallback to Rails.logger/STDOUT if not.
What do you think?

@dziemian007
Copy link
Author

Looks like travis build fails, maybe update used Ruby versions?

/home/travis/.rvm/gems/ruby-1.9.3-p547/gems/sidekiq-3.2.5/lib/sidekiq.rb:3:in `<top (required)>': Sidekiq 3.2.5 does not support Ruby 1.9. (RuntimeError)

@arthurnn
Copy link
Owner

not sure why this is better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants