Update index.js #18
Open
Update index.js #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added two new options, stringDays, which will allow somebody to translate into any language the days list , also added the timeFormat, which accepts two values (hh:mm or HH:MM) and does the obvious.
| @@ -37,7 +39,7 @@ | |||
| * @public | |||
| */ | |||
| DayScheduleSelector.prototype.renderHeader = function () { | |||
| var stringDays = ['Sun', 'Mon', 'Tue', 'Wed', 'Thu', 'Fri', 'Sat'] | |||
| var stringDays = this.options.stringDays | |||
There was a problem hiding this comment.
This is a good idea, and we should figure out a way to do internationalization for other labels, too. 👍
|
Yay! Thanks for the FIRST pull request here! I have some comments inline. See if that makes sense to you. Also, I set up the tests with Karma. The test coverage is still very low now, and if you can add those covering your changes, that will be awesome. You can install I will add a tests section to the readme. Let me know if you have any questions. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added two new options, stringDays, which will allow somebody to translate into any language the days list , also added the timeFormat, which accepts two values (hh:mm or HH:MM) and does the obvious.