Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Material mapping and assignment #138

Merged

Conversation

ClemensLinnhoff
Copy link
Collaborator

@ClemensLinnhoff ClemensLinnhoff commented Oct 10, 2024

Describe your changes

  • Put material mapping in separate file.
  • Add texture assignment to asset file.
  • Restructure documentation to contain the different files.

Check out the implemented documentation on my fork:
https://clemenslinnhoff.github.io/OpenMATERIAL/asamopenmaterial/latest/specification/index.html

Issue ticket number and link

Fixes #46, fixes #51, fixes #109

Checklist before requesting a review

  • I have performed a self-review of my code/documentation.
  • My changes generate no new warnings during the documentation generation.

Signed-off-by: ClemensLinnhoff <[email protected]>
Signed-off-by: ClemensLinnhoff <[email protected]>
Signed-off-by: ClemensLinnhoff <[email protected]>
Signed-off-by: ClemensLinnhoff <[email protected]>
Signed-off-by: ClemensLinnhoff <[email protected]>
Signed-off-by: ClemensLinnhoff <[email protected]>
Signed-off-by: ClemensLinnhoff <[email protected]>
Copy link
Member

@AsamDiegoSanchez AsamDiegoSanchez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed
Signed-off by: Diego Sánchez [email protected]

@ClemensLinnhoff
Copy link
Collaborator Author

@LudwigFriedmann could you also review this, if the new structure would work for you? This also contains the decision to have a material texture assignment in the asset file and the material mapping in a separate mapping file.
The description of the general file structure however is not implemented here, yet.

Signed-off-by: ClemensLinnhoff <[email protected]>
@ClemensLinnhoff
Copy link
Collaborator Author

As soon as this is merged I will create an example to showcase both the mapping via texture and via mesh.

Copy link
Collaborator

@LudwigFriedmann LudwigFriedmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LudwigFriedmann LudwigFriedmann merged commit 5b86549 into asam-ev:main Oct 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants