153 review definitions in schema files #172
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 11, 2024 19:55
…F being removed. To be discussed. Signed-off-by: TimoHinsemann <[email protected]>
Signed-off-by: TimoHinsemann <[email protected]>
Signed-off-by: TimoHinsemann <[email protected]>
There was a problem hiding this comment.
We need to adapt the brdf examples, because we removed two columns here.
| }, | ||
| { | ||
| "type": ["number", "null"], | ||
| "description": "Phase within the linearly polarized plane. If the phase is not taken into account, it is null." | ||
| "description": "BRDF value in 1/sr." | ||
| } | ||
| ], | ||
| "minItems": 7, |
There was a problem hiding this comment.
Number of items needs to be changed. And we should probably also add a maxItems
| }, | ||
| { | ||
| "type": ["number", "null"], | ||
| "description": "Amplitude within the linearly polarized plane." | ||
| "description": "Wavelength of radiation in meters." |
There was a problem hiding this comment.
Let's make the wavelength the first column, because the table shall be sorted by the first column and then it is sorted by wavelength.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Edit definitions
Issue ticket number and link
Fixes #153
Checklist before requesting a review