Add customProperties field to material file #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modified: schemas/material_schema.json
Closed
ClemensLinnhoff
requested changes
Nov 28, 2024
There was a problem hiding this comment.
I propose slight adjustments to the schema definitions.
Would this be okay for you @Norihito-Hiruma?
Signed-off-by: ClemensLinnhoff <[email protected]>
Signed-off-by: ClemensLinnhoff <[email protected]>
ClemensLinnhoff
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
modified: schemas/material_schema.json
Describe your changes
In response to the result of the discussion in issue #182, customProperties have been added to the material file schema.
Some questions to ask:
I have added an item with reference to glTF's extensions, so please review it.
Issue ticket number and link
Related issue is #182.