150 discuss remaining notes on vehicle structure #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added hitch_front and hitch_back
|
I added hitches to the group_dynamic rather than group_static. Just in case we want to make hitches detachable or rotatable inwards (deactivated state). However, there are so many rotation axes common, that I did not define the hitch origin or rotation axis exactly. |
Signed-off-by: ClemensLinnhoff <[email protected]>
|
I just did some editorial fixes, like putting the hitch definition in alphabetical order and changing the term "back" to "rear" for harmonization with the other definitions. Are these changes okay for you @MatthiasThDs? If yes, @ACMackenthun can start on the illustrations. |
|
perfect |
ACMackenthun
reviewed
Dec 3, 2024
ACMackenthun
approved these changes
Dec 3, 2024
…ture Signed-off-by: Clemens <[email protected]>
ClemensLinnhoff
deleted the
150-discuss-remaining-notes-on-vehicle-structure
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
According to #150, I added hitches to the vehicle structure.
Fixes #203