Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Antora configuration setup #22

Merged
merged 7 commits into from
Jun 26, 2024
Merged

Antora configuration setup #22

merged 7 commits into from
Jun 26, 2024

Conversation

nakohdo
Copy link
Collaborator

@nakohdo nakohdo commented Jun 21, 2024 •
edited
Loading

Fix broken symlinks

The symlinks were broken because of problems that can happen when using them under Windows with Git for Windows. See https://stackoverflow.com/questions/5917249/git-symbolic-links-in-windows for details.

Add GitHub workflow action

Based on OSI configuration. Not yet configured for OpenMATERIAL.

Related issue: #23

nakohdo added 2 commits June 21, 2024 14:31
@nakohdo
Fix symlinks.
acb5ebe 
Signed-off-by: Frank Ralf <[email protected]>
@nakohdo
Remove broken symlinks.
184fd55 
Signed-off-by: Frank Ralf <[email protected]>
@nakohdo nakohdo requested a review from AsamDiegoSanchez June 21, 2024 14:04
@nakohdo nakohdo changed the title Antora configuration: Fix symlinks Antora configuration setup Jun 21, 2024
@ClemensLinnhoff
Copy link
Collaborator

@nakohdo one of your commits is missing the DCO.

@nakohdo nakohdo force-pushed the antora-configuration branch from ab83fab to bc120b3 Compare June 25, 2024 07:56
@nakohdo
Copy link
Collaborator Author

nakohdo commented Jun 25, 2024

@ClemensLinnhoff
Fixed the commit message.

ClemensLinnhoff
ClemensLinnhoff reviewed Jun 25, 2024
View reviewed changes
Copy link
Collaborator

@ClemensLinnhoff ClemensLinnhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this PR ready for review? It looks like it is still under development. If so, please mark it as Draft.

.github/workflows/demo-workflow.yml Outdated Show resolved Hide resolved
.github/workflows/antora-build.yml Show resolved Hide resolved
.antora/modules/specification/pages/_images/overview_open_x.png Show resolved Hide resolved
@nakohdo nakohdo marked this pull request as draft June 25, 2024 08:48
@nakohdo
Remove demo workflow.
acac11a 
Signed-off-by: Frank Ralf <[email protected]>
@nakohdo nakohdo marked this pull request as ready for review June 25, 2024 08:54
@ClemensLinnhoff ClemensLinnhoff added the isState:ForCCBreview CCB will review it and change the status to ReadyForMerge if everything is ok label Jun 26, 2024
@ClemensLinnhoff
Copy link
Collaborator

CCB decision 26.06.24: Merge as is.
Parson did an internal check of the content of the PR. The end result will only be seen after another PR setting up GitHub pages.

@ClemensLinnhoff ClemensLinnhoff merged commit be94702 into main Jun 26, 2024
2 checks passed
@ClemensLinnhoff ClemensLinnhoff deleted the antora-configuration branch June 26, 2024 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClemensLinnhoff ClemensLinnhoff ClemensLinnhoff approved these changes

@AsamDiegoSanchez AsamDiegoSanchez Awaiting requested review from AsamDiegoSanchez

Assignees
No one assigned
Labels
isState:ForCCBreview CCB will review it and change the status to ReadyForMerge if everything is ok
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nakohdo @ClemensLinnhoff