Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix symlinks #27

Merged
merged 2 commits into from
Jul 4, 2024
Merged

Fix symlinks #27

merged 2 commits into from
Jul 4, 2024

Conversation

nakohdo
Copy link
Collaborator

@nakohdo nakohdo commented Jul 2, 2024

The symlinks for the default Antora folders "pages" and "images" were broken so the actual content was duplicated. I removed the folders and recreated the symlinks.

@ClemensLinnhoff
Copy link
Collaborator

I would like to merge everything concerning the setup of the documentation page as soon as possible. These types of PRs are very hard to review anyways. @AsamDiegoSanchez can we expedite the merge of this without format CCB approval?

@nakohdo Will this get the GitHub pages docu page working? Or is there still something missing? I think there is already something there at https://asam-ev.github.io/OpenMATERIAL/.

@nakohdo
Copy link
Collaborator Author

nakohdo commented Jul 4, 2024

@ClemensLinnhoff
No, this is just to fix the symlinks that somehow were broken again. This will only make the documentation conform to the required Antora folder structure as a prerequisite for the build process.

I want to keep both things separate so there will be a separate PR for the publication on GitHub Pages. What you can see there was created from a test branch, not yet from "main".

@ClemensLinnhoff
Copy link
Collaborator

Then @AsamDiegoSanchez let's merge this asap, so we can move on with the implementation.

@ClemensLinnhoff ClemensLinnhoff self-requested a review July 4, 2024 10:53
@AsamDiegoSanchez
Copy link
Member

Thank you @nakohdo.
Agree, let´s merge it so we can start.

@ClemensLinnhoff ClemensLinnhoff merged commit 91f386e into main Jul 4, 2024
2 checks passed
@ClemensLinnhoff ClemensLinnhoff deleted the fix-symlinks branch August 22, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants