Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve environment variables in framework manifest file #157

Merged
merged 11 commits into from
Sep 2, 2024
Merged

Resolve environment variables in framework manifest file #157

merged 11 commits into from
Sep 2, 2024

Conversation

hoangtungdinh
Copy link
Collaborator

@hoangtungdinh hoangtungdinh commented Sep 2, 2024 •
edited
Loading

Description

Before, environment variables were only resolved in Module manifest files. Now, environment variable resolution is also supported in Framework manifest files.

Main changes

  1. Add environment variable resolution for framework manifest files.
  2. Update documentation

How was the PR tested?

  1. Tested via github action.

Notes
Fix #156

@hoangtungdinh
workflow: Install runtime from locally cloned repo
8aa1365 
Signed-off-by: hoangtungdinh <[email protected]>
@hoangtungdinh
workflow: Install runtime from local repo on Windows
6bbb372 
Signed-off-by: hoangtungdinh <[email protected]>
@hoangtungdinh
Make test fails with new requirements
aba8b24 
Signed-off-by: hoangtungdinh <[email protected]>
@hoangtungdinh
Resolve environment variables in framework manifest file
120b73a 
Signed-off-by: hoangtungdinh <[email protected]>
@hoangtungdinh
Update model validation
8cc5a90 
Signed-off-by: hoangtungdinh <[email protected]>
@hoangtungdinh
Make test fails with module environment variables
f843815 
Signed-off-by: hoangtungdinh <[email protected]>
@hoangtungdinh
Add more printing
95e3251 
Signed-off-by: hoangtungdinh <[email protected]>
@hoangtungdinh
Update printing
c435313 
Signed-off-by: hoangtungdinh <[email protected]>
@hoangtungdinh
Update documentation
8ddc90c 
Signed-off-by: hoangtungdinh <[email protected]>
@hoangtungdinh hoangtungdinh changed the title Support resolving local environment variables Resolve environment variables in framework manifest file Sep 2, 2024
@hoangtungdinh hoangtungdinh marked this pull request as ready for review September 2, 2024 09:17
@hoangtungdinh hoangtungdinh linked an issue Sep 2, 2024 that may be closed by this pull request
Resolving environment variables in manifest file #156
Closed
@hoangtungdinh
Update doc
04170a5 
Signed-off-by: hoangtungdinh <[email protected]>
@hoangtungdinh
Update doc
527ad99 
Signed-off-by: hoangtungdinh <[email protected]>
patrickpa
patrickpa approved these changes Sep 2, 2024
View reviewed changes
Copy link
Contributor

@patrickpa patrickpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hoangtungdinh

@hoangtungdinh hoangtungdinh merged commit a2ef192 into develop Sep 2, 2024
4 checks passed
@hoangtungdinh hoangtungdinh deleted the tung/support-env-var branch September 2, 2024 09:41
hoangtungdinh added a commit that referenced this pull request Sep 11, 2024
@hoangtungdinh
Resolve environment variables in framework manifest file (#157)
668af44 
Signed-off-by: hoangtungdinh <[email protected]>
@hoangtungdinh hoangtungdinh mentioned this pull request Sep 11, 2024
Merged
hoangtungdinh added a commit that referenced this pull request Oct 10, 2024
@hoangtungdinh
Resolve environment variables in framework manifest file (#157)
cd1c132 
Signed-off-by: hoangtungdinh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickpa patrickpa patrickpa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Resolving environment variables in manifest file
2 participants
@hoangtungdinh @patrickpa