-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 3rd party licenses and bump version to 1.0.0 #208
Conversation
Signed-off-by: hoangtungdinh <[email protected]>
I was reviewing it, and maybe it is because I do not know them, but I think we need to input a short description of the 3rd dependencies, i.e "Black_LICENSE", what is it or what is this for? and link it to the file or source code where it is use... Similar to what we did already here: https://github.com/asam-ev/qc-framework/blob/main/licenses/readme.md |
I've also thought about that topic.... in the mentioned existing file we added "non-standard" information:
The bottom line is that it might be meaningful to add information
Because these two use cases might make a difference when people talk to legal. Didn't see any critical things... all are standard Open Source components, which are used everywhere. If we want to be really good, that one sentence might be interesting for what/why we use it. This might help in understanding why we did not want to implement everything from scratch. A description of the 3rd party dep is not necessary IMHO, because it is public available, PyPI homepage could be linked for example. Then it's also clear that this comes via PIP and not necessary to download a source code. This whole topic is difficult, because there is always somebody who needs more information 🤣 |
Hi @AsamDiegoSanchez @andreaskern74 . I added a short description for each dependency (just how it is used in our codebase) and links to them on PyPi server, where they are downloaded. I will also do that for other repos. |
Signed-off-by: hoangtungdinh <[email protected]>
2b405b8
to
62a77e3
Compare
@hoangtungdinh : Looks really good! |
Thanks @hoangtungdinh! Yes, I think it is much clear now. @andreaskern74 if you also agree, we can tag it as ready "ForCCBReview". I will also add @MatteoRagni and @pmai |
Will be merged for releasing.... |
Description
This PR adds 3rd party licenses and updates the version to 1.0.0
How was the PR tested?
Notes
Related issue: #207