Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI/CD: Add tests to workflows #58

Merged
merged 29 commits into from
May 27, 2024
Merged

Conversation

patrickpa
Copy link
Contributor

@patrickpa patrickpa commented May 24, 2024

Description

This PR adds tests steps to build workflows to be executed on new PRs.

The test are not executed on main/develop merge actions, since we assume the code is tested and is working on the PR targeting that branches.

Main changes

  1. Add tests to Linux build workflow
  2. Add tests to Windows build workflow

How was the PR tested?

  1. The workflows being executed successfully on this PR are the test needed to ensure this work on other PRs.

Linux workflow when the whole workflow was triggered:

https://github.com/asam-ev/qc-framework/actions/runs/9252909091/job/25451510916

Windows workflow when the whole workflow was triggered:

https://github.com/asam-ev/qc-framework/actions/runs/9252909087/job/25451510940

Notes

  • The current test step is added as an extra step on the build workflow, for now this is the fastest way to get the test and the build with no much code rewriting and in a easy to read way.
  • The current test does not include the XSD files for OpenScenario and OpenDrive tests since there is no public available download to it. We need to evaluate if it is a blocking factor.

patrickpa added 24 commits May 24, 2024 15:18
Signed-off-by: Patrick Abrahão <[email protected]>
Signed-off-by: Patrick Abrahão <[email protected]>
Signed-off-by: Patrick Abrahão <[email protected]>
Signed-off-by: Patrick Abrahão <[email protected]>
Signed-off-by: Patrick Abrahão <[email protected]>
Signed-off-by: Patrick Abrahão <[email protected]>
Signed-off-by: Patrick Abrahão <[email protected]>
Signed-off-by: Patrick Abrahão <[email protected]>
Signed-off-by: Patrick Abrahão <[email protected]>
Signed-off-by: Patrick Abrahão <[email protected]>
Signed-off-by: Patrick Abrahão <[email protected]>
Signed-off-by: Patrick Abrahão <[email protected]>
Signed-off-by: Patrick Abrahão <[email protected]>
@patrickpa patrickpa marked this pull request as ready for review May 27, 2024 09:10
@patrickpa patrickpa self-assigned this May 27, 2024
patrickpa added 3 commits May 27, 2024 11:23
…o patrick/add_tests_cicd

Signed-off-by: Patrick Abrahão <[email protected]>
Signed-off-by: Patrick Abrahão <[email protected]>
Copy link
Collaborator

@hoangtungdinh hoangtungdinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work, thanks @patrickpa

@hoangtungdinh hoangtungdinh merged commit f76b14e into develop May 27, 2024
1 check passed
@hoangtungdinh hoangtungdinh deleted the patrick/add_tests_cicd branch May 27, 2024 11:01
hoangtungdinh pushed a commit that referenced this pull request Jun 4, 2024
hoangtungdinh pushed a commit that referenced this pull request Jun 5, 2024
Signed-off-by: Patrick Abrahão <[email protected]>

Signed-off-by: Patrick Abrahão <[email protected]>
hoangtungdinh pushed a commit that referenced this pull request Jun 5, 2024
Signed-off-by: Patrick Abrahão <[email protected]>

Signed-off-by: Patrick Abrahão <[email protected]>
hoangtungdinh pushed a commit that referenced this pull request Jun 5, 2024
Signed-off-by: Patrick Abrahão <[email protected]>

Signed-off-by: Patrick Abrahão <[email protected]>
pmai pushed a commit that referenced this pull request Jun 6, 2024
Signed-off-by: Patrick Abrahão <[email protected]>
Signed-off-by: Patrick Abrahão <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants