-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update result file schema and add demo pipeline #86
Conversation
Signed-off-by: romanodanilo <[email protected]> Signed-off-by: romanodanilo <[email protected]>
Signed-off-by: romanodanilo <[email protected]> Signed-off-by: romanodanilo <[email protected]>
Signed-off-by: romanodanilo <[email protected]> Signed-off-by: romanodanilo <[email protected]>
Signed-off-by: romanodanilo <[email protected]> Signed-off-by: romanodanilo <[email protected]>
Signed-off-by: romanodanilo <[email protected]> Signed-off-by: romanodanilo <[email protected]>
Signed-off-by: romanodanilo <[email protected]> Signed-off-by: romanodanilo <[email protected]>
Signed-off-by: romanodanilo <[email protected]> Signed-off-by: romanodanilo <[email protected]>
Signed-off-by: romanodanilo <[email protected]> Signed-off-by: romanodanilo <[email protected]>
Signed-off-by: romanodanilo <[email protected]> Signed-off-by: romanodanilo <[email protected]>
Signed-off-by: romanodanilo <[email protected]> Signed-off-by: romanodanilo <[email protected]>
Signed-off-by: romanodanilo <[email protected]> Signed-off-by: romanodanilo <[email protected]>
69b8a46
to
3c150b2
Compare
Signed-off-by: hoangtungdinh <[email protected]> Signed-off-by: hoangtungdinh <[email protected]>
3c150b2
to
eff0729
Compare
Signed-off-by: romanodanilo <[email protected]> Signed-off-by: romanodanilo <[email protected]> Signed-off-by: hoangtungdinh <[email protected]> Signed-off-by: hoangtungdinh <[email protected]>
Signed-off-by: hoangtungdinh <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall the changes look good to me.
The minor point I'm raising on the XML/Schema front is for architectural discussion: We should likely tighten down the schema quite a bit more, and be careful about the semantics of attribute values: Usually you want to distinguish a missing value from an empty string/value. But again this is for future direction and PRs, I think.
|
||
<CheckerBundle build_date="" description="" name="DemoCheckerBundle" summary="Found 3 issues" version=""> | ||
<Checker checkerId="exampleChecker" description="This is a description" status="completed" summary=""> | ||
<Issue description="This is an information from the demo usecase" issueId="0" level="3" ruleUID=""/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should a non-exisiting ruleUID not be handled via eliding the attribute rather than supplying an empty string?
More generally I think going forward the schema should be tightened down to specify required attributes (currently all are optional) and more specific types for the attributes, where useful (which would e.g. disallow empty strings in places where IDs are required). This is less of a comment on the current PR, but again more for the forward-looking architectural discussions.
@AsamDiegoSanchez @hoangtungdinh same here: was this officially approved in the CCB? Then we should tag as ready for merge, and I can perform the merge. |
yes, it was approved without any further comments |
Description
This PR is ready for CCB's review.
This PR updates the result file schema, taking into account all the requirements. All related C++ classes are also updated to reflect the new schema.
This PR also adds a docker-based demo pipeline that supports the checker bundles for OpenDrive and OpenScenario.
Main changes
How was the PR tested?
Notes
This PR closes the following issues