Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo, xml path and descriptions #116

Merged
merged 1 commit into from
Nov 4, 2024
Merged

Fix typo, xml path and descriptions #116

merged 1 commit into from
Nov 4, 2024

Conversation

hoangtungdinh
Copy link
Contributor

Description

This PR addresses #115 and include some minor improvements as detailed below.

Main changes

  1. Fix a typo in some descriptions
  2. For issues related to the performance rules "redundant elements", point to the most specific XML element in the XML xpaths, instead of just pointing to the parent road.
  3. Add content to all empty descriptions. Now, no description is empty.
  4. Add more XML XPath to some issues (e.g., when there are a redundant lane width declaration, both the first declaration and the redundant declaration are included in the XML XPath).

How was the PR tested?

  1. Unit-test

Notes
Related issues: #115

@hoangtungdinh hoangtungdinh added the isState:ForCCBReview CCB will review it and change the status to ReadyForMerge if everything is ok label Oct 30, 2024
andreaskern74
andreaskern74 approved these changes Oct 30, 2024
View reviewed changes
Copy link
Collaborator

@andreaskern74 andreaskern74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, also some good improvements

@MircoNierenz
Copy link
Collaborator

our issue (see #115) is solved

AsamDiegoSanchez
AsamDiegoSanchez approved these changes Nov 4, 2024
View reviewed changes
Copy link
Member

@AsamDiegoSanchez AsamDiegoSanchez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also all good from my side.

@andreaskern74 andreaskern74 merged commit 167ad80 into main Nov 4, 2024
7 checks passed
@andreaskern74 andreaskern74 deleted the ivex/tung/fix-type-and-xml-loc branch November 4, 2024 08:06
@andreaskern74 andreaskern74 added isState:Integrated An issue that has been integrated and has an integration reviewer and removed isState:ForCCBReview CCB will review it and change the status to ReadyForMerge if everything is ok labels Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AsamDiegoSanchez AsamDiegoSanchez AsamDiegoSanchez approved these changes

@andreaskern74 andreaskern74 andreaskern74 approved these changes

@MatteoRagni MatteoRagni MatteoRagni approved these changes

Assignees
No one assigned
Labels
isState:Integrated An issue that has been integrated and has an integration reviewer
Projects
Quality Checker
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hoangtungdinh @MircoNierenz @MatteoRagni @andreaskern74 @AsamDiegoSanchez