Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI/CD and implement the first two rules #19

Closed
wants to merge 9 commits into from
Closed

Conversation

hoangtungdinh
Copy link
Contributor

Description

This PR is ready for CCB's review.

This PR sets up the structure of the repository, creates CI/CD and implements the first two rules using the Python Base Library.

Main changes

  1. The original implementation is moved to the original_implementation folder so that it can still be easily accessed and used as the reference implementation for the new rules. Towards the end of the project, the folder original_implementation will be removed.
  2. Add CI/CD
  3. Implement two rules: road.lane.access.no_mix_of_deny_or_allow and road.lane.level_true_one_side. Note that, the WARNING logic in the rule road.lane.level_true_one_side is not complete for now.

How was the PR tested?

  1. Tests are documented in each PR above.

Notes

This PR will close the following issue:

Signed-off-by: Patrick Abrahão <[email protected]>
Signed-off-by: Patrick Abrahão <[email protected]>
Signed-off-by: patrickpa <[email protected]>
Signed-off-by: Patrick Abrahão <[email protected]>
Signed-off-by: patrickpa <[email protected]>
Signed-off-by: Patrick Abrahão <[email protected]>
Signed-off-by: patrickpa <[email protected]>
Signed-off-by: Patrick Abrahão <[email protected]>
Signed-off-by: patrickpa <[email protected]>
Signed-off-by: Patrick Abrahão <[email protected]>
Signed-off-by: patrickpa <[email protected]>
Signed-off-by: Patrick Abrahão <[email protected]>
Signed-off-by: patrickpa <[email protected]>
Signed-off-by: Patrick Abrahão <[email protected]>
@hoangtungdinh hoangtungdinh added the isState:ForCCBReview CCB will review it and change the status to ReadyForMerge if everything is ok label Jun 18, 2024
Copy link
Collaborator

@pmai pmai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation looks good to me.

Maybe I missed something in discussions, but I'm unsure why the original implementation is just moved into a sub-directory rather than deleting it? If we want to re-use something from it in the future, its still in the history, so why not clean up now?

@hoangtungdinh
Copy link
Contributor Author

@pmai, the reason we keep the original implementation is that it is easier to access and use as a reference when implementing the rule, as we don't have to search the commit history or another branch to find the original implementation. However, I can see that it causes confusion. We will remove the original implementation in the next sprint.

@pmai
Copy link
Collaborator

pmai commented Jun 20, 2024

@pmai, the reason we keep the original implementation is that it is easier to access and use as a reference when implementing the rule, as we don't have to search the commit history or another branch to find the original implementation. However, I can see that it causes confusion. We will remove the original implementation in the next sprint.

You can easily keep two revisions checked out out in parallel, either using a local clone, or using the git worktree add <path> feature for multi-worktrees from a single repo, which is what I would recommend for temporary reference use.

If we are going to remove it anyway I would definitely recommend doing it already in this PR (I can provde the necessary commit cleanup prior to merging), as otherwise the history is already screwed up a bit (file moves rather than file deletion, which can get confusing both for humans and in certain cases for some advanced git commands).

General opinions on this? @asam-ev/qc_ccb

@hoangtungdinh
Copy link
Contributor Author

I agree @pmai . We will add the removal to this PR.

@hoangtungdinh
Copy link
Contributor Author

I am closing this PR as we now have #49 carrying all the commits from this PR.

@andreaskern74 andreaskern74 removed the isState:ForCCBReview CCB will review it and change the status to ReadyForMerge if everything is ok label Jul 18, 2024
@hoangtungdinh hoangtungdinh deleted the 2024-06-18 branch July 30, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants