Refactor to use one checker per rule #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hoangtungdinh <[email protected]>
Signed-off-by: hoangtungdinh <[email protected]>
patrickpa
approved these changes
Sep 16, 2024
hoangtungdinh
added a commit
that referenced
this pull request
Sep 25, 2024
Signed-off-by: hoangtungdinh <[email protected]>
Merged
hoangtungdinh
added a commit
that referenced
this pull request
Sep 25, 2024
Signed-off-by: hoangtungdinh <[email protected]>
hoangtungdinh
added a commit
that referenced
this pull request
Oct 31, 2024
Signed-off-by: hoangtungdinh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This refactoring guarantees that one checker contains only one rule. Besides refactoring, many tests are also added to check for the status of the checkers.
Main changes
How was the PR tested?
Notes
Related issue: asam-ev/qc-framework#163