Check input string before double conversion in non negative checks #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: romanodanilo <[email protected]>
hoangtungdinh
approved these changes
Jul 29, 2024
hoangtungdinh
pushed a commit
that referenced
this pull request
Jul 30, 2024
Signed-off-by: romanodanilo <[email protected]>
hoangtungdinh
pushed a commit
that referenced
this pull request
Aug 1, 2024
Signed-off-by: romanodanilo <[email protected]> Signed-off-by: romanodanilo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Check input string before double conversion in non negative checks
This PR follows the test on public openscenario example where reading the value "1,2" was crashing the checker execution
Now it skips the checks as the value sign cannot be interpreted if the double string is not well formed
How was the PR tested?
Notes