Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add maintenance work #64

Merged
merged 5 commits into from
Sep 26, 2024
Merged

Add maintenance work #64

merged 5 commits into from
Sep 26, 2024

Conversation

hoangtungdinh
Copy link
Contributor

@hoangtungdinh hoangtungdinh commented Sep 25, 2024 •
edited
Loading

Description

This PR adds various minor maintenance tasks.

Main changes

  1. Refactor and cleanup the architecture
  2. Update issue descriptions
  3. Add summary to the result

How was the PR tested?

  1. Tests are documented in each PR

Notes

This PR close asam-ev/qc-framework#161

hoangtungdinh and others added 5 commits September 25, 2024 11:35
@hoangtungdinh
Refactor and clean up (#59)
57d776e 
Signed-off-by: hoangtungdinh <[email protected]>
@romanodanilo @hoangtungdinh
Update issue description (#61)
1490d25 
Signed-off-by: romanodanilo <[email protected]>
Signed-off-by: romanodanilo <[email protected]>
@hoangtungdinh
Add summary to the result (#60)
c388edd 
Signed-off-by: hoangtungdinh <[email protected]>
Co-authored-by: hoangtungdinh <[email protected]>
@hoangtungdinh
Add exception to log (#62)
b7b90de 
Signed-off-by: hoangtungdinh <[email protected]>
@hoangtungdinh
Use new functions from baselib (#63)
db135aa 
Signed-off-by: hoangtungdinh <[email protected]>
Co-authored-by: hoangtungdinh <[email protected]>
@hoangtungdinh hoangtungdinh added the isState:ForCCBReview CCB will review it and change the status to ReadyForMerge if everything is ok label Sep 25, 2024
@AsamDiegoSanchez
Copy link
Member

in CCB reviewed. Ready for merge

@AsamDiegoSanchez AsamDiegoSanchez added isState:ReadyForMerge An issue that has been integrated and is assigned to the workflow manager and removed isState:ForCCBReview CCB will review it and change the status to ReadyForMerge if everything is ok labels Sep 26, 2024
AsamDiegoSanchez
AsamDiegoSanchez approved these changes Sep 26, 2024
View reviewed changes
Copy link
Member

@AsamDiegoSanchez AsamDiegoSanchez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in CCB reviewed. Ready for merge
Signed-off by: Diego Sánchez [email protected]

@andreaskern74 andreaskern74 merged commit 6a214fe into main Sep 26, 2024
7 checks passed
@andreaskern74 andreaskern74 deleted the 2024-09-25 branch September 26, 2024 14:03
@andreaskern74 andreaskern74 added isState:Integrated An issue that has been integrated and has an integration reviewer and removed isState:ReadyForMerge An issue that has been integrated and is assigned to the workflow manager labels Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AsamDiegoSanchez AsamDiegoSanchez AsamDiegoSanchez approved these changes

Assignees
No one assigned
Labels
isState:Integrated An issue that has been integrated and has an integration reviewer
Projects
Quality Checker
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CheckerBundle and Checker summary is empty
4 participants
@hoangtungdinh @AsamDiegoSanchez @andreaskern74 @romanodanilo