Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Nextstrain functionality #42

Merged
merged 23 commits into from
Sep 26, 2024
Merged

Add Nextstrain functionality #42

merged 23 commits into from
Sep 26, 2024

Conversation

JenkeScheen
Copy link
Contributor

With CLI endpoint so that we can download gene mutation data from https://nextstrain.org/pathogens#list

@JenkeScheen
Copy link
Contributor Author

@hmacdope this is now working for all viruses/genes that we have available in https://github.com/asapdiscovery/choppa/blob/nextstrain/choppa/data/metadata/nextstrain.json. There are a few viruses that we'd like to include (MERS-CoV, WNV) but their NextStrain entries are too borked (gene nomenclature is way off).

Can you check why CI is failing here and review plz?

Copy link
Contributor

@hmacdope hmacdope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, super minor stuff. I will fix tests

choppa/nextstrain.py Outdated Show resolved Hide resolved
choppa/nextstrain.py Outdated Show resolved Hide resolved
choppa/nextstrain.py Show resolved Hide resolved
devtools/conda-envs/choppa.yaml Outdated Show resolved Hide resolved
@hmacdope hmacdope changed the title [WIP] Add Nextstrain functionality Add Nextstrain functionality Sep 26, 2024
Copy link
Contributor

@hmacdope hmacdope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for making the changes @JenkeScheen

@hmacdope hmacdope merged commit 630af43 into main Sep 26, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants