-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Nextstrain functionality #42
Conversation
@hmacdope this is now working for all viruses/genes that we have available in https://github.com/asapdiscovery/choppa/blob/nextstrain/choppa/data/metadata/nextstrain.json. There are a few viruses that we'd like to include (MERS-CoV, WNV) but their NextStrain entries are too borked (gene nomenclature is way off). Can you check why CI is failing here and review plz? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, super minor stuff. I will fix tests
Co-authored-by: Hugo MacDermott-Opeskin <[email protected]>
Co-authored-by: Hugo MacDermott-Opeskin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for making the changes @JenkeScheen
With CLI endpoint so that we can download gene mutation data from https://nextstrain.org/pathogens#list