Add RcppParallel cxxflags to makevars #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asardaes
reviewed
May 16, 2024
src/Makevars
Outdated
| @@ -1,4 +1,5 @@ | |||
| PKG_CXXFLAGS += -DRCPP_USE_UNWIND_PROTECT | |||
| KG_CXXFLAGS += $(shell ${R_HOME}/bin/Rscript -e "RcppParallel::CxxFlags()") | |||
There was a problem hiding this comment.
There's a typo, an initial P is missing. Also, where did you find this information? The documentation doesn't mention this.
There was a problem hiding this comment.
There's a typo, an initial P is missing.
Oh good catch, sorry about that!
Also, where did you find this information? The documentation doesn't mention this.
The CxxFlags function didn't previously have much use for packages, but the TBB headers needs additional compilation flags on Windows ARM64
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates your Makevars to add RcppParallel's CXXFLAGS, which will be needed for compatibility with Windows ARM64