Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font related improvements #412

Merged
merged 4 commits into from
Apr 4, 2023
Merged

Font related improvements #412

merged 4 commits into from
Apr 4, 2023

Conversation

ku1ik
Copy link
Contributor

@ku1ik ku1ik commented Apr 3, 2023

This exposes player's terminalLineHeight in the form of a number input on the recording settings page, which addresses:

Also allows selecting Nerd Font (Fira Code or JetBrains Mono) instead of default font for a recording, which addresses:

@ku1ik ku1ik merged commit 0081f9e into develop Apr 4, 2023
@skonik
Copy link

skonik commented Apr 8, 2023

Awesome

@jonpetersathan
Copy link
Contributor

Any chance we can get this in the self-hosted version as well? Or is there an option to configure this manually via custom.exs?

@ku1ik
Copy link
Contributor Author

ku1ik commented Mar 24, 2024

Hey @jonpetersathan, this is included in the self-hosted version. You don't see those new options in the recording settings form?

@jonpetersathan
Copy link
Contributor

jonpetersathan commented Mar 24, 2024

@ku1ik Ah yeah, sorry, there I do see the settings indeed! But is there a way to change the default settings? Like you can on https://asciinema.org/user/edit, because on the self hosted version, I can only change the terminal theme in the user settings form.

Edit: Ah I think I know why, I assume this isn't available yet, in the latest docker image: #431 - got it now, thanks! In that case I will create my own image for now.

@ku1ik
Copy link
Contributor Author

ku1ik commented Mar 25, 2024

I've released new version yesterday: https://github.com/asciinema/asciinema-server/releases/tag/v20240324

And yes, there's no global setting (yet), but I plan to add it.

@jonpetersathan
Copy link
Contributor

@ku1ik: With the new version, I can know see the settings per user. Thanks!
I also tried to make NerdFonts work in iframes and created a pull request: #434.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants