Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Cargo Sparse protocol in Docker build #439

Merged
merged 1 commit into from
Apr 28, 2024
Merged

Conversation

jippi
Copy link
Contributor

@jippi jippi commented Apr 27, 2024

Cargo 1.68 and newer introduced "sparse" protocol which significantly reduces memory usage (and improves build time!) - see https://blog.rust-lang.org/inside-rust/2023/01/30/cargo-sparse-protocol.html

Had to bump Alpine to 3.18 to pick up a more recent Cargo release (1.76.0)

hexpm/elixir do not sure Alpine 3.19 with current erlang+elixir combination

Should fix the CI error 137 on current main

#26 [linux/arm64 builder  5/18] RUN cd native/vt_nif && cargo build -r
#26 2.171     Updating crates.io index
#26 ERROR: process "/dev/.buildkit_qemu_emulator /bin/sh -c cd native/vt_nif && cargo build -r" did not complete successfully: exit code: 137

Cargo 1.68 and newer introduced "sparse" protocol which significantly reduces memory usage (and improves build time!) - see https://blog.rust-lang.org/inside-rust/2023/01/30/cargo-sparse-protocol.html

Had to bump Alpine to 3.18 to pick up a more recent Cargo release (1.76.0)

hexpm/elixir do not sure Alpine 3.19 with current erlang+elixir combination
@ku1ik
Copy link
Contributor

ku1ik commented Apr 28, 2024

Awesome, thank you!

@ku1ik ku1ik merged commit d0c66e8 into asciinema:develop Apr 28, 2024
1 check passed
@jippi jippi deleted the patch-1 branch April 28, 2024 09:53
@ku1ik
Copy link
Contributor

ku1ik commented Apr 28, 2024

Just noticed that Alpine 3.18 has Rust 1.71.1, not 1.76, but it did the trick since it's >= 1.68: https://github.com/asciinema/asciinema-server/actions/runs/8866724397 🎉

@jippi
Copy link
Contributor Author

jippi commented Apr 28, 2024

Fantastic 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants