Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: improvements and simplification of python and docker packaging #1

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

olivierkeke
Copy link

This PR improves python and docker packaging:

  • Rename the package enoceanmqtt in HA_enoceanmqtt to avoid conflicts with enocean-mqtt library.
  • Remove useless copy of enocean-mqtt modules.
  • Create a separate main module to replace patched main function of enocean-mqtt.
  • Move Dockerfile at the root of the repository so that python sources are in the build context.
  • Copy directly python sources in the docker image.

I've pushed a working docker image on dockerhub: docker pull hollysaiqs/ha_enoceanmqtt:latest

Please notice that standalone installation files must also be modified.

@olivierkeke
Copy link
Author

olivierkeke commented Sep 20, 2024

It seems that the new TCPClientCommunicator is not compatible with this PR since the enoceanmqtt package has been modified inside this repository 😲

My understanding is that 795e270 should have be merged on https://github.com/embyt/enocean-mqtt and not in this project.

@tostmann Can you please submit this PR on https://github.com/embyt/enocean-mqtt as suggested by @mak-gitdev?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant