Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vnext #483

Merged
merged 1 commit into from
Nov 12, 2024
Merged

vnext #483

merged 1 commit into from
Nov 12, 2024

Conversation

gertd
Copy link
Member

@gertd gertd commented Nov 11, 2024

  • updates to adopt go-aserto@vnext changes

@coveralls
Copy link

coveralls commented Nov 11, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11788129554

Details

  • 2 of 10 (20.0%) changed or added relevant lines in 8 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.009%) to 8.537%
Changes Missing Coverage Covered Lines Changed/Added Lines %
cmd/topazd/topaz_run.go 0 1 0.0%
pkg/app/directory/simple_resolver.go 0 1 0.0%
pkg/cli/editor/editor.go 0 1 0.0%
pkg/cli/editor/internal/runtime/runtime.go 0 1 0.0%
plugins/edge/plugin.go 0 1 0.0%
pkg/app/topaz.go 0 3 0.0%
Totals Coverage Status
Change from base Build 11714541659: -0.009%
Covered Lines: 772
Relevant Lines: 9043
💛 - Coveralls

@gertd gertd requested a review from ronenh November 11, 2024 22:25
ronenh
ronenh previously approved these changes Nov 11, 2024
View reviewed changes
@gertd
adopt go-aserto@vnext changes
3be7ce1 
PASS make test & make test-templates

update deps

update to use variadic dopts

use tagged updated packages
@aserto-bot aserto-bot merged commit 820e137 into main Nov 12, 2024
5 checks passed
@aserto-bot aserto-bot deleted the vnext branch November 12, 2024 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aserto-bot aserto-bot aserto-bot approved these changes

@ronenh ronenh ronenh left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gertd @coveralls @ronenh @aserto-bot