Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: add search path to postgres functions #449

Merged

Conversation

alexslade
Copy link
Contributor

This is a minor hardening of postgres security, in response to supabase advisor warnings.

It's only been added to the new migration generator, it's not serious enough to try and address elsewhere. This should mean that anyone setting up a new app will get these new settings.

Closes #396

@zachdaniel Sorry for the delay posting this!

  • I'm not sure how much further to test this. The changes have been applied to our app for a couple of months, no issues.
  • Tests pass (but I'd be surprised if there was coverage for this minor postgres setting)
  • I created a new app, ran the generator and deployed to supabase: can confirm the warnings are gone

Before:

372654290-21878677-278a-4be3-b13b-08099406e81c

After:

Screenshot 2024-12-24 at 23 16 46

Contributor checklist

  • Bug fixes include regression tests (Not applicable)
  • Features include unit/acceptance tests (Not applicable)

@alexslade alexslade changed the title build: add search path to postgres functions bug: add search path to postgres functions Dec 24, 2024
This is a minor hardening of postgres security, in response to supabase
advisor warnings.

It's only been added to the new migration generator, it's not serious
enough to try and address elsewhere. This should mean that anyone
setting up a new app will get these new settings.

Closes ash-project#396
@alexslade alexslade force-pushed the add-search-path-to-postgres-functions branch from eed9913 to ac3e51d Compare December 24, 2024 23:21
@zachdaniel zachdaniel merged commit 7e0c205 into ash-project:main Dec 25, 2024
@zachdaniel
Copy link
Contributor

🚀 Thank you for your contribution! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Supabase Linter reports warnings with default Ash functions
2 participants