Fix switch statements missing a default branch #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed the compiler error when a `switch` statement was missing an `default` branch. Now it will compile cleanly.
ekosz
force-pushed
the
E/failing-switch-test
branch
from
687cd85 to
6a3d8b4
Compare
ekosz
changed the title
|
Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #127
Currently this is just adding a failing test for when one does not add a default to a switch. Happy to try and fix the issue as well, but this will be my first time debugging Spark DSLs so I may need a bit of guidance.I found the issue and this PR now both adds a test as well as the fix. I also tried following the conventional commits, but please let me know if you would like me to update anything.
Contributor checklist