Bug fix **kwargs requirement in RPC callback fn (#113)

aspectron · Oct 26, 2024 · f8128e7 · f8128e7
1 parent bdc2198
commit f8128e7
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/python/examples/rpc_subscriptions.py b/python/examples/rpc_subscriptions.py
@@ -6,9 +6,13 @@
 def subscription_callback(event, name, **kwargs):
     print(f"{name} | {event}")
 
+def block_added_handler(event):
+    print(f"block_added_handler: {event}")
+
 async def rpc_subscriptions(client: RpcClient):
     # client.add_event_listener("all", subscription_callback, callback_id=1, kwarg1="Im a kwarg!!")
     client.add_event_listener("all", subscription_callback, name="all")
+    client.add_event_listener("block-added", block_added_handler)
 
     await client.subscribe_virtual_daa_score_changed()
     await client.subscribe_virtual_chain_changed(True)

diff --git a/rpc/wrpc/python/src/client.rs b/rpc/wrpc/python/src/client.rs
@@ -268,7 +268,11 @@ impl RpcClient {
         let event = NotificationEvent::from_str(event.as_str()).unwrap();
 
         let args = args.to_object(py).extract::<Py<PyTuple>>(py)?;
-        let kwargs = kwargs.unwrap().to_object(py).extract::<Py<PyDict>>(py)?;
+
+        let kwargs = match kwargs {
+            Some(kw) => kw.to_object(py).extract::<Py<PyDict>>(py)?,
+            None => PyDict::new_bound(py).into(),
+        };
 
         let py_callback = PyCallback { callback, args: Some(args), kwargs: Some(kwargs) };