Skip to content

Commit

Permalink
[css-scroll-snap-1] Update Changes, add DoC
Browse files Browse the repository at this point in the history
  • Loading branch information
fantasai committed Jan 2, 2019
1 parent c1c4508 commit 1e4e0fc
Show file tree
Hide file tree
Showing 3 changed files with 136 additions and 1 deletion.
9 changes: 8 additions & 1 deletion css-scroll-snap-1/Overview.bs
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ Shortname: css-scroll-snap
TR: https://www.w3.org/TR/css-scroll-snap-1/
Level: 1
Status: ED
Previous Version: https://www.w3.org/TR/2018/CR-css-scroll-snap-1-20180814/
Previous Version: https://www.w3.org/TR/2017/CR-css-scroll-snap-1-20171214/
Previous Version: https://www.w3.org/TR/2017/CR-css-scroll-snap-1-20170824/
Previous Version: https://www.w3.org/TR/2017/CR-css-scroll-snap-1-20170209/
Expand Down Expand Up @@ -1118,11 +1119,17 @@ Changes Since 14 August 2018 CR {#changes-20180814}

<ul>
<li id="change-2018-padding-intial">
Corrected 'scroll-padding' longhand property definition tables to list the new ''scroll-padding/auto'' keyword as their initial value.
Corrected 'scroll-padding' longhands to list the new ''scroll-padding/auto'' keyword in their property definition tables.
(<a href="https://github.com/w3c/csswg-drafts/issues/3189">Issue 3189</a>)
<li id="change-2018-computed-animation">
Fixed up “Computed value” and “Animation type” lines in the property definition tables.
<li id="change-2018-margin-percentage">
Cleaned up stray <<percentage>> values in 'scroll-margin' property definition tables.
(<a href="https://github.com/w3c/csswg-drafts/issues/3289">3289</a>)
</ul>

A <a href="https://drafts.csswg.org/css-scroll-snap-1/issues-cr-2018">Disposition of Comments is available</a>.

Changes Since 14 December 2017 CR {#changes-20171214}
---------------------------------------------------

Expand Down
29 changes: 29 additions & 0 deletions css-scroll-snap-1/issues-cr-2018.bsi
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
Draft: https://www.w3.org/TR/2018/CR-css-scroll-snap-1-20180814/
Title: CSS Scroll Snap Module Level 1

----
Issue 1.
Summary: scroll-padding longhands property grammars missing 'auto' keyword
From: Eric Willigers
Comment: https://github.com/w3c/csswg-drafts/issues/3189
Response: https://github.com/w3c/csswg-drafts/issues/3189#issuecomment-427950014
Closed: Accepted
Verified: https://github.com/w3c/csswg-drafts/issues/3189#issuecomment-428022790
Resolved: Bugfix
----
Issue 2.
Summary: Typo in Changes section
From: Philippe Cloutier
Comment: https://github.com/w3c/csswg-drafts/issues/3269
Response: https://github.com/w3c/csswg-drafts/issues/3269#issuecomment-435014942
Closed: Accepted
Resolved: Editorial
----
Issue 3.
Summary: Do scroll-margin-* accept percentages?
From: Eric Willigers
Comment: https://github.com/w3c/csswg-drafts/issues/3289
Response: https://github.com/w3c/csswg-drafts/issues/3289#issuecomment-438808689
Closed: Accepted
Resolved: Bugfix
----
99 changes: 99 additions & 0 deletions css-scroll-snap-1/issues-cr-2018.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,99 @@
<!DOCTYPE html>
<meta charset="utf-8">
<title>CSS Scroll Snap Module Level 1 Disposition of Comments for 2018-08-14 CR</title>
<style type="text/css">
pre { border: solid thin silver; padding: 0.2em; white-space: normal; }
pre > span { display: block; white-space: pre; }
.a { background: #52E052 }
.d { background: #8CCBF2 }
.oi { background: #E0CB52 }
.r { background: orange }
.fo { background: #f66 }
pre.a { background: #E9FBE9 }
pre.d { background: #DEF }
pre.oi { background: #FCFAEE }
pre.r { background: #FFEECC }
pre.fo { background: #FBE9E9 }
.open { border: solid red; }
:target { box-shadow: 0.25em 0.25em 0.25em; }
a[href^=mid], a[href~=flatten] { text-decoration: none; }
abbr { font-weight: bold; }
</style>

<h1>CSS Scroll Snap Module Level 1 Disposition of Comments for 2018-08-14 CR</h1>

<p>Dated Draft: <a href="https://www.w3.org/TR/2018/CR-css-scroll-snap-1-20180814/">https://www.w3.org/TR/2018/CR-css-scroll-snap-1-20180814/</a>

<p>Editor's Draft: <a href="http://drafts.csswg.org/css-scroll-snap-1/">http://drafts.csswg.org/css-scroll-snap-1/</a>

<p>The following color coding convention is used for comments:</p>

<ul>
<li class="a">Accepted or Rejected and positive response
<li class="r">Rejected and no response
<li class="fo">Rejected and negative response
<li class="d">Deferred
<li class="oi">Out-of-Scope or Invalid and not verified
</ul>

<p class=open>Open issues are marked like this</p>

<p>An issue can be closed as <code>Accepted</code>, <code>OutOfScope</code>,
<code>Invalid</code>, <code>Rejected</code>, or <code>Retracted</code>.
<code>Verified</code> indicates commentor's acceptance of the response.</p>
<pre class=' a' id='issue-1'>
<span>Issue 1. <a href='#issue-1'>#</a></span>
<span>Summary: scroll-padding longhands property grammars missing 'auto' keyword</span>
<span>From: Eric Willigers</span>
<span>Comment: <a href='https://github.com/w3c/csswg-drafts/issues/3189'>https://github.com/w3c/csswg-drafts/issues/3189</a></span>
<span>Response: <a href='https://github.com/w3c/csswg-drafts/issues/3189#issuecomment-427950014'>https://github.com/w3c/csswg-drafts/issues/3189#issuecomment-427950014</a></span>
<span class="a">Closed: Accepted</span>
<span class="a">Verified: <a href='https://github.com/w3c/csswg-drafts/issues/3189#issuecomment-428022790'>https://github.com/w3c/csswg-drafts/issues/3189#issuecomment-428022790</a></span>
<span>Resolved: Bugfix</span></pre>
<pre class=' a' id='issue-2'>
<span>Issue 2. <a href='#issue-2'>#</a></span>
<span>Summary: Typo in Changes section</span>
<span>From: Philippe Cloutier</span>
<span>Comment: <a href='https://github.com/w3c/csswg-drafts/issues/3269'>https://github.com/w3c/csswg-drafts/issues/3269</a></span>
<span>Response: <a href='https://github.com/w3c/csswg-drafts/issues/3269#issuecomment-435014942'>https://github.com/w3c/csswg-drafts/issues/3269#issuecomment-435014942</a></span>
<span class="a">Closed: Accepted</span>
<span>Resolved: Editorial</span></pre>
<pre class=' a' id='issue-3'>
<span>Issue 3. <a href='#issue-3'>#</a></span>
<span>Summary: Do scroll-margin-* accept percentages?</span>
<span>From: Eric Willigers</span>
<span>Comment: <a href='https://github.com/w3c/csswg-drafts/issues/3289'>https://github.com/w3c/csswg-drafts/issues/3289</a></span>
<span>Response: <a href='https://github.com/w3c/csswg-drafts/issues/3289#issuecomment-438808689'>https://github.com/w3c/csswg-drafts/issues/3289#issuecomment-438808689</a></span>
<span class="a">Closed: Accepted</span>
<span>Resolved: Bugfix</span></pre>
<script>
(function () {
var sheet = document.styleSheets[0];
function addCheckbox(className) {
var element = document.querySelector('*.' + className);
var span = document.createElement('span');
span.innerHTML = element.innerHTML;
element.innerHTML = null;
var check = document.createElement('input');
check.type = 'checkbox';
if (className == 'open') {
check.checked = false;
sheet.insertRule('pre:not(.open)' + '{}', sheet.cssRules.length);
check.onchange = function (e) {
rule.style.display = this.checked ? 'none' : 'block';
}
}
else {
check.checked = true;
sheet.insertRule('pre.' + className + '{}', sheet.cssRules.length);
check.onchange = function (e) {
rule.style.display = this.checked ? 'block' : 'none';
}
}
var rule = sheet.cssRules[sheet.cssRules.length - 1];
element.appendChild(check);
element.appendChild(span);
}
['a', 'd', 'fo', 'oi', 'r', 'open'].forEach(addCheckbox);
}());
</script>

0 comments on commit 1e4e0fc

Please sign in to comment.