Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit test for File Tokenizer #4

Merged
merged 12 commits into from
Nov 21, 2024

Conversation

TheFJcurve
Copy link
Collaborator

@TheFJcurve TheFJcurve commented Nov 13, 2024

  • Added unit test for file tokenizer (current coverage is 100%)
  • Changed file tokenizer's get_block_content function to stop looking at the original file to get back the original data
  • Changed the hashing and de-hashing functions to encoding and decoding (hashes cannot be dehashed)
  • Current implementation of encoding and decoding gives back the original data itself, that will have to be done
  • Added more type safety across the repo
  • config file contains more information, the goal should be not to hardcode anything
  • Github workflows work for all branches and all PRs, works hand in hand for any forks.
  • Created a common test file, to share some file writing and deleting features without double coding.
  • Current pylint score 9.83

@TheFJcurve TheFJcurve added the WIP Work in Progress (Don't review the PR) label Nov 13, 2024
@TheFJcurve TheFJcurve marked this pull request as ready for review November 15, 2024 17:29
@TheFJcurve TheFJcurve added Ready for Review We can now have some reviews to merge the PR and removed WIP Work in Progress (Don't review the PR) labels Nov 15, 2024
@TheFJcurve TheFJcurve requested a review from asterbot November 15, 2024 17:30
@TheFJcurve TheFJcurve merged commit 3ff40b8 into asterbot:main Nov 21, 2024
2 checks passed
@TheFJcurve TheFJcurve deleted the test_file_tokenizer branch November 21, 2024 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready for Review We can now have some reviews to merge the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants