Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write Unit Test for P2P Client #5

Closed
wants to merge 15 commits into from
Closed

Write Unit Test for P2P Client #5

wants to merge 15 commits into from

Conversation

TheFJcurve
Copy link
Collaborator

@TheFJcurve TheFJcurve commented Nov 21, 2024 •
edited
Loading

  • test for p2p client now 88%
  • Created a class for SenderSocket and ReceiverSocket for their respective socket use. Made test cases for both of them.
  • Our backend has a few defined API calls. To make their logic centralized, created ClientMessage class, with its own set of MessageType and MessageError
  • Made P2PClient functions compact, and much more meaningful.
  • created unit tests for ClientMessage

@TheFJcurve TheFJcurve added the WIP Work in Progress (Don't review the PR) label Nov 21, 2024
@TheFJcurve TheFJcurve marked this pull request as ready for review December 8, 2024 04:31
@TheFJcurve TheFJcurve requested a review from asterbot December 8, 2024 04:31
@TheFJcurve TheFJcurve added Ready for Review We can now have some reviews to merge the PR and removed WIP Work in Progress (Don't review the PR) labels Dec 8, 2024
@TheFJcurve TheFJcurve closed this Dec 11, 2024
@TheFJcurve TheFJcurve deleted the test_p2p_client branch December 11, 2024 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asterbot asterbot Awaiting requested review from asterbot

Assignees
No one assigned
Labels
Ready for Review We can now have some reviews to merge the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@TheFJcurve