Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced SIPp -mp with -min_rtp_port #25

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

maurice2k
Copy link
Contributor

SIPp parameter -mp has been replaced with -min_rtp_port in SIPp v3.7.0 (released April 2023).

@maurice2k maurice2k changed the title Replace SIPp -mp with -min_rtp_port Replaced SIPp -mp with -min_rtp_port Dec 12, 2023
@@ -714,7 +714,7 @@ def __evaluate_scenario_results(result):
default_args[defarg] = ('%s/sipp/%s' % (
self.test_dir, default_args[defarg]))

if '-mp' not in default_args:
if '-min_rtp_port' not in default_args:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not backwards compatible. Personally the SIPp I use isn't new enough to have this, so it would no longer work for me. I'm on Ubuntu 22.04, so I expect others would experience the same. Is the version shipping in distributions or has to be built manually? Is it possible to make this backwards compatible to support both based on detection of the version?

@gtjoseph
Copy link
Member

gtjoseph commented May 16, 2024

A little sipp history... In 3.5.2, all 3 options (-mp, -min_rtp_port, -max_rtp_port) were available. In 3.6.0, they dropped -min_rtp_port and -max_rtp_port "This removes a chunk of unnecessary rtpstream code". In 3.7.0, the same person who dropped the options, put them back again but removed the -mp option. After 3.7.2 was released, someone else put the -mp option back in but without help text so it doesn't show up when you do a sipp --help. Today, I submitted a PR to add the help text back in which was just merged. This should be available when they release v3.7.3.

So now to answer @jcolp's question... Fedora 40 actually ships sipp-3.7.2 but as far as I can tell, no other distro does and altrough I do use Fedora 40, I build and use the same sipp version that the testsuite contrib/scripts/install_prereq script istalls...v3.6.1. That's the version anyone who runs the testsuite should use if they want repeatable results.

So @maurice2k you'd need to do a few things if you want to make this compatible with various versions but I'm not sure it's worth the trouble. If we do upgrade the sipp version the testsuite uses, we'd wait for v3.7.3 to get the -mp option back.

  • Leave the yaml files all specifying -mp
  • Check the version to see which option -mp or -min_rtp_port is supported by that version and set the default to it.
  • Check the arguments passed by the iterator and replace occurrences of those options with the ones valid for the sipp version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants