pjsip/info-dtmf: Change to WaitDigit to make more reliable #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cherry-pick-to: 18 |
github-actions
bot
added
pr-submit-tests-passed
and removed
pr-submit-testing-in-progress
labels
jcolp
reviewed
Nov 11, 2024
| @@ -272,7 +272,7 @@ | |||
| Content-Type: application/dtmf-relay | |||
| Content-Length: [len] | |||
|
|
|||
| Signal=10 | |||
| Signal=A | |||
There was a problem hiding this comment.
Were these incorrect in the first place?
There was a problem hiding this comment.
No. Either is acceptable but the letters/symbols are clearer than the numbers. I couldn't find the numbers for the symbols anyway. :)
github-actions
bot
added
cherry-pick-testing-in-progress
jcolp
approved these changes
Nov 14, 2024
github-actions
bot
added
pre-merge-testing-in-progress
pre-merge-checks-passed
merge-in-progress
and removed
merge-approved
pre-merge-testing-in-progress
labels
asterisk-org-access-app
bot
merged commit 464a335
into
asterisk:master
31 checks passed
|
Successfully merged to branch master and cherry-picked to ["18","20","21","22","certified/18.9","certified/20.7"] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.