Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Program params and enum Discardxx #119

Merged
merged 23 commits into from
Dec 18, 2024
Merged

Conversation

oldma3095
Copy link
Contributor

@oldma3095 oldma3095 commented Dec 13, 2024

Program.Flags()
Program.SetFlags(f int)
Program.Discard()
Program.SetDiscard(d Discard)
Program.StreamIndex()
Program.Metadata()
Program.SetMetadata(d *Dictionary)
Program.ProgramNum()
Program.SetProgramNum(n int)
Program.PmtPid()
Program.PcrPid()
Program.PmtVersion()
Program.StartTime()
Program.EndTime()
Program.PtsWrapReference()
Program.PtsWrapBehavior()
DiscardNone          = Discard(C.AVDISCARD_NONE)     // discard nothing
DiscardDefault       = Discard(C.AVDISCARD_DEFAULT)  // discard useless packets like 0 size packets in avi
DiscardNonRef        = Discard(C.AVDISCARD_NONREF)   // discard all non reference
DiscardBidirectional = Discard(C.AVDISCARD_BIDIR)    // discard all bidirectional frames
DiscardNonIntra      = Discard(C.AVDISCARD_NONINTRA) // discard all non intra frames
DiscardNonKey        = Discard(C.AVDISCARD_NONKEY)   // discard all frames except keyframes
DiscardAll           = Discard(C.AVDISCARD_ALL)      // discard all

discard.go Outdated Show resolved Hide resolved
discard_test.go Outdated Show resolved Hide resolved
program.go Outdated Show resolved Hide resolved
program.go Outdated Show resolved Hide resolved
program.go Show resolved Hide resolved
program_test.go Outdated Show resolved Hide resolved
program_test.go Outdated Show resolved Hide resolved
program_test.go Outdated Show resolved Hide resolved
program_test.go Outdated Show resolved Hide resolved
program.go Outdated Show resolved Hide resolved
@oldma3095
Copy link
Contributor Author

add two functions.
CodecContext.MaxBFrames()
CodecContext.SetMaxBFrames(n int)

@asticode
Copy link
Owner

add two functions. CodecContext.MaxBFrames() CodecContext.SetMaxBFrames(n int)

Can you please create another PR for this?

@oldma3095
Copy link
Contributor Author

oldma3095 commented Dec 17, 2024

add two functions. CodecContext.MaxBFrames() CodecContext.SetMaxBFrames(n int)

Can you please create another PR for this?

i will create a new pr.
merge this pr first plz.

@asticode
Copy link
Owner

merge this pr first plz

Sure, I'm waiting for my last comments to be addressed first 👍

program_test.go Outdated Show resolved Hide resolved
@asticode asticode merged commit e9341fd into asticode:master Dec 18, 2024
3 checks passed
@asticode
Copy link
Owner

Thanks a lot for sticking with this PR! ❤️

@asticode
Copy link
Owner

FYI I've removed Program.StreamIndex() and Program.SetStreamIndex() since I realized program.stream_index is in fact an array of stream indexes and was already made available by Program.Streams() 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants