Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add string representation to log level #49

Closed
wants to merge 7 commits into from
Closed

Add string representation to log level #49

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
43ff653
add string representation to log level
leandromoreira Feb 27, 2024
7f7c027
Add tests for log level string representation
leandromoreira Feb 27, 2024
19b2fbe
move String method down
leandromoreira Feb 27, 2024
682804b
improve lot tester
leandromoreira Feb 27, 2024
8f4db84
declare unexposed c function
leandromoreira Feb 27, 2024
c95e576
expose log.c function symbol
leandromoreira Feb 27, 2024
32af090
return proper type
leandromoreira Feb 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions log.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,11 @@ import "unsafe"

type LogLevel int

// https://github.com/FFmpeg/FFmpeg/blob/release/5.1/libavutil/log.c#L268
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove the comment here?

func (l LogLevel) String() {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you move this function below constants?

return C.GoString(C.get_level_str(C.int(l)))
}

// https://github.com/FFmpeg/FFmpeg/blob/n5.0/libavutil/log.h#L162
const (
LogLevelQuiet = LogLevel(C.AV_LOG_QUIET)
Expand Down
4 changes: 4 additions & 0 deletions log_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ func TestLog(t *testing.T) {
lis = append(lis, logItem{
fmt: fmt,
l: l,
lString: l.String(),
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove lStrings and instead add require.Equal(t, "error", astiav.LogLevelError) at the top of the test function?

msg: msg,
})
})
Expand All @@ -31,16 +32,19 @@ func TestLog(t *testing.T) {
{
fmt: "warning",
l: astiav.LogLevelWarning,
lString: "warning",
msg: "warning",
},
{
fmt: "error",
l: astiav.LogLevelError,
lString: "error",
msg: "error",
},
{
fmt: "fatal",
l: astiav.LogLevelFatal,
lString: "fatal",
msg: "fatal",
},
}, lis)
Expand Down