Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setter and getter for extra_hw_frames #52

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

l0rem1psum
Copy link
Contributor

Added this because I need to use it :)

@l0rem1psum l0rem1psum force-pushed the feat-extra-hw-frames branch from d845979 to 8bfe3fc Compare March 11, 2024 10:42
codec_context.go Outdated
@@ -314,6 +314,14 @@ func (cc *CodecContext) SetHardwareDeviceContext(hdc *HardwareDeviceContext) {
}
}

func (cc *CodecContext) ExtraHwFrames() int {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you rename to ExtraHardwareFrames?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

codec_context.go Outdated
return int(cc.c.extra_hw_frames)
}

func (cc *CodecContext) SetExtraHwFrames(n int) {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you rename to SetExtraHardwareFrames?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@l0rem1psum l0rem1psum force-pushed the feat-extra-hw-frames branch from 8bfe3fc to a3a029b Compare March 12, 2024 01:39
@l0rem1psum l0rem1psum force-pushed the feat-extra-hw-frames branch from a3a029b to c7b0b44 Compare March 12, 2024 01:40
@asticode asticode merged commit a4f27be into asticode:master Mar 12, 2024
3 checks passed
@asticode
Copy link
Owner

Thanks for the PR ❤️

Let me know whether you need a tag 👍

@l0rem1psum l0rem1psum deleted the feat-extra-hw-frames branch November 4, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants