Check if the frame is writable before copyPlanes #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asticode
requested changes
Oct 14, 2024
There was a problem hiding this comment.
At first I forced the frame to be writable by adding .MakeWritable() when copying planes but then I realized the developer should be free to decide when to make the frame writable. However checking whether the frame is writable seems like a good idea even though I don't really know whether this is a big performance drop 👍
Could you also add tests for this use case? Something like the following added here(after a newline)
f3 := astiav.AllocFrame()
defer f3.Free()
require.NoError(t, f3.Ref(f2))
require.Error(t, fd2.FromImage(i1))
require.Error(t, fd2.SetBytes(b1, align))
kurochan
commented
Oct 14, 2024
asticode
requested changes
Oct 14, 2024
frame_data_test.go
Outdated
| require.NoError(t, f3.Ref(f2)) | ||
| require.Error(t, fd2.FromImage(i1)) | ||
| require.Error(t, fd2.SetBytes(b1, align)) | ||
| f3.MakeWritable() |
There was a problem hiding this comment.
f2 should be the frame that we make writable here
|
Thanks for the PR! ❤️ Let me know whether you need a tag 👍 |
|
Please tag this as well 🚀 |
|
I've created a |
asticode
pushed a commit
that referenced
this pull request
Oct 23, 2024
* check if the frame is writable before copyPlanes * apply review * make f2 writable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For safety of frame operations, check if the frame is writable before copyPlanes.
If this seems to be a performance overhead, I would like input as this PR may not be necessary.