Skip to content

Commit

Permalink
windows: filter out static extensions before checking for presence
Browse files Browse the repository at this point in the history
Otherwise static can fail if ignore_static is set but ignore_missing
isn't.
  • Loading branch information
indygreg committed Oct 3, 2020
1 parent 5286109 commit 3fe9cb9
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions cpython-windows/build.py
Original file line number Diff line number Diff line change
Expand Up @@ -1598,16 +1598,16 @@ def collect_python_build_artifacts(
dirs = {p for p in os.listdir(intermediates_path)}

for extension, entry in CONVERT_TO_BUILTIN_EXTENSIONS.items():
if static and entry.get("ignore_static"):
continue

if extension not in dirs:
if entry.get("ignore_missing"):
continue
else:
log("extension not present: %s" % extension)
sys.exit(1)

if static and entry.get("ignore_static"):
continue

extension_projects.add(extension)
if static:
depends_projects |= set(entry.get("static_depends", []))
Expand Down

0 comments on commit 3fe9cb9

Please sign in to comment.