Skip to content

Commit

Permalink
Use Visual Studio 2022 for builds instead of 2019 (#377)
Browse files Browse the repository at this point in the history
  • Loading branch information
zanieb authored Oct 29, 2024
1 parent 55787ea commit 6e1ce43
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 4 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/windows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ concurrency:
jobs:
pythonbuild:
if: ${{ github.repository_owner == 'indygreg' || github.event_name != 'schedule' }}
runs-on: 'windows-2019'
runs-on: 'windows-2022'
steps:
- uses: actions/checkout@v4

Expand Down Expand Up @@ -66,7 +66,7 @@ jobs:
options: 'freethreaded+pgo'

needs: pythonbuild
runs-on: 'windows-2019'
runs-on: 'windows-2022'
steps:
- uses: actions/checkout@v4
with:
Expand Down Expand Up @@ -96,7 +96,7 @@ jobs:
- name: Build
shell: cmd
run: |
call "C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Auxiliary\Build\${{ matrix.vcvars }}"
call "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Auxiliary\Build\${{ matrix.vcvars }}"
py.exe -3.9 build-windows.py --python ${{ matrix.py }} --sh c:\cygwin\bin\sh.exe --options ${{ matrix.options }}
- name: Validate Distribution
Expand Down
2 changes: 1 addition & 1 deletion cpython-windows/build.py
Original file line number Diff line number Diff line change
Expand Up @@ -1887,7 +1887,7 @@ def main() -> None:
parser.add_argument(
"--vs",
choices={"2019", "2022"},
default="2019",
default="2022",
help="Visual Studio version to use",
)
parser.add_argument(
Expand Down
1 change: 1 addition & 0 deletions src/validation.rs
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,7 @@ const PE_ALLOWED_LIBRARIES: &[&str] = &[
"USERENV.dll",
"VERSION.dll",
"VCRUNTIME140.dll",
"VCRUNTIME140_1.dll",
"WINMM.dll",
"WS2_32.dll",
// Our libraries.
Expand Down

0 comments on commit 6e1ce43

Please sign in to comment.