Disable cron for forks #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! This makes sense to me. I feel like we could also just disable the scheduled jobs entirely as I don't really use them in any way. |
Merged
|
Okay, here we go! #384 |
zanieb
added a commit
that referenced
this pull request
Oct 29, 2024
* Revert "Disable cron for forks (#383)" This reverts commit 55787ea. * Disable cron schedule --------- Co-authored-by: Zanie Blue <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only run the scheduled cron for upstream:
https://dev.to/hugovk/til-how-to-disable-cron-for-github-forks-2d0l
This is a big CI matrix, we don't need to run the cron on forks, but contributors might nevertheless want run the CI before opening a PR (and clogging up the upstream CI queue).
Background: when pushing stuff to other repos, I was wondering why it was taking a long time for jobs to get a runner, but only in the afternoon, and for two or three hours.
After checking it's not a GitHub outage, I figured out it must be a cron from another repo I'd forked. But not so easy to find when you have over 1,000 forks! So I wrote a script to call the
ghCLI to find which repo currently had a running CI, and surprise, surprise, it was this big 'un! :D(As it happens, I got to use the same script a few days later to find another running in the morning!)