Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge with upstream #2

Merged
merged 1 commit into from
Jan 17, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- Add a test for asynchronous Interchain Query relaying
([\#3455](https://github.com/informalsystems/hermes/issues/3455))
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- Add an ICA test to assert a channel correctly closes after a packet time-outs
([\#3778](https://github.com/informalsystems/hermes/issues/3778))
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
- Add a `client_refresh_rate` setting to specify the rate at which to
refresh clients referencing this chain, relative to its trusting period.
([\#3402](https://github.com/informalsystems/hermes/issues/3402))
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
- Add a `--packet-sequences` flag to the `clear packets`, `tx packet-recv`, and `tx packet-ack` commands.
When this flag is specified, these commands will only clear the packets with the specified sequence numbers
on the given chain. If not provided, all pending packets will be cleared on both chains, as before.

This flag takes either a single sequence number or a range of sequences numbers.
Each element of the comma-separated list must be either a single sequence number or
a range of sequence numbers.

Examples:
- `10` will clear a single packet with sequence nymber `10`
- `1,2,3` will clear packets with sequence numbers `1, 2, 3`
- `1..5` will clear packets with sequence numbers `1, 2, 3, 4, 5`
- `..5` will clear packets with sequence numbers `1, 2, 3, 4, 5`
- `5..` will clear packets with sequence numbers greater than or equal to `5`
- `..5,10..20,25,30..` will clear packets with sequence numbers `1, 2, 3, 4, 5, 10, 11, ..., 20, 25, 30, 31, ...`
- `..5,10..20,25,30..` will clear packets with sequence numbers `1, 2, 3, 4, 5, 10, 11, ..., 20, 25, 30, 31, ...`

([\#3672](https://github.com/informalsystems/hermes/issues/3672))
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
- Add a `query_packets_chunk_size` config option and a `--query-
packets-chunk-size flag to the `clear packets` CLI to configure how
many packets to query at once from the chain when clearing pending
packets. Lower this setting if one or more of packets you are
trying to clear are huge and make the packet query time out or fail.
([\#3743](https://github.com/informalsystems/hermes/issues/3743))
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
- Add two new packet configurations:
* `ics20_max_memo_size` which filters ICS20 packets with memo
field bigger than the configured value
* `ics20_max_receiver_size` which filters ICS20 packets with receiver
field bigger than the configured value
([\#3766](https://github.com/informalsystems/hermes/issues/3766))
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- Update compatibility check to allow IBC-Go 4.1.1 to 8.x and SDK 0.45.x to 0.50.x.
([\#3745](https://github.com/informalsystems/hermes/issues/3745))
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
- Fix a bug in the `evidence` command which would sometimes
prevent the detected misbehaviour evidence from being submitted,
instead erroring out with a validator set hash mismatch.
([\#3697](https://github.com/informalsystems/hermes/pull/3697))
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
- Avoid retrieving a worker which is being removed by the idle worker clean-up
process.
process ([\#3703](https://github.com/informalsystems/hermes/issues/3703))
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
- Fix the issue where `broadcast_errors` metric would not correctly batch
the same errors together.
together ([\#3720](https://github.com/informalsystems/hermes/issues/3720))
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
- Update the values of `backlog` metrics when clearing packets.
Change the `backlog_oldest_timestamp` to `backlog_latest_update_timestamp`
which shows the last time the `backlog` metrics have been updated.
([\#3723](https://github.com/informalsystems/hermes/issues/3723))
9 changes: 9 additions & 0 deletions .changelog/v1.7.4/summary.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
*December 15th, 2023*

This release improves the monitoring of Hermes instances by fixing the `broadcast_errors` metric so
that it correctly batches the same errors together. It also improves the metrics `backlog_*` by
updating them whenever Hermes queries pending packets.

This release also improves the reliability of the idle worker clean-up and
fixes a bug within the `evidence` command which would sometimes prevent
the misbehaviour evidence from being reported.
3 changes: 3 additions & 0 deletions .github/codespell/codespell.ini
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
[codespell]
skip = *.js,*.ts,*.css,*.svg,*.html,*.json,./target,./tools/integration-test/data,./tools/check-guide/target,./ci/misbehaviour/data
ignore-words = .github/codespell/words.txt
4 changes: 4 additions & 0 deletions .github/codespell/words.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
crate
shs
ser
numer
12 changes: 11 additions & 1 deletion .github/workflows/cargo-doc.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,17 @@ on:
push:
branches:
- master
pull_request: {}
paths:
- .github/workflows/cargo-doc.yml
- Cargo.toml
- Cargo.lock
- crates/**
pull_request:
paths:
- .github/workflows/cargo-doc.yml
- Cargo.toml
- Cargo.lock
- crates/**

# Cancel previous runs of this workflow when a new commit is added to the PR, branch or tag
concurrency:
Expand Down
22 changes: 22 additions & 0 deletions .github/workflows/codespell.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
name: Codespell
on:
pull_request:
push:
branches: master

# Cancel previous runs of this workflow when a new commit is added to the PR, branch or tag
concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
cancel-in-progress: true

jobs:
codespell:
name: Check spelling
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: codespell-project/actions-codespell@v2
with:
skip: '*.js,*.ts,*.css,*.svg,*.html,*.json,./target,./tools/integration-test/data,./tools/check-guide/target,./ci/misbehaviour/data'
ignore_words_file: .github/codespell/words.txt

17 changes: 10 additions & 7 deletions .github/workflows/docker.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,10 @@ jobs:
fail-fast: false
matrix:
platform:
- linux/amd64
- linux/arm64
- id: linux/amd64
name: amd64
- id: linux/arm64
name: arm64
steps:
- name: Checkout
uses: actions/checkout@v4
Expand Down Expand Up @@ -49,7 +51,7 @@ jobs:
with:
context: .
file: ./ci/release/hermes.Dockerfile
platforms: ${{ matrix.platform }}
platforms: ${{ matrix.platform.id }}
labels: ${{ steps.meta.outputs.labels }}
outputs: type=image,name=${{ env.REGISTRY_IMAGE }},push-by-digest=true,name-canonical=true,push=true
cache-from: type=gha
Expand All @@ -62,9 +64,9 @@ jobs:
touch "/tmp/digests/${digest#sha256:}"

- name: Upload digest
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: digests
name: digests-${{ matrix.platform.name }}
path: /tmp/digests/*
if-no-files-found: error
retention-days: 1
Expand All @@ -75,9 +77,10 @@ jobs:
- docker-build
steps:
- name: Download digests
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: digests
pattern: digests-*
merge-multiple: true
path: /tmp/digests

- name: Set up Docker Buildx
Expand Down
Loading
Loading