Iolin #221
Iolin #221
Conversation
| @@ -16,7 +16,7 @@ | |||
| "outputs": [], | |||
| "source": [ | |||
| "__author__ = 'Ragadeepika Pucha <[email protected]>, Stephanie Juneau <[email protected]>'\n", | |||
| "__version__ = '20230914' \n", | |||
| "__version__ = '20230914' #yyyymmdd\n", | |||
| @@ -1638,9 +1638,9 @@ | |||
| ], | |||
| "metadata": { | |||
| "kernelspec": { | |||
| "display_name": "DESI 23.1", | |||
| "display_name": "Python 3 (ipykernel)", | |||
There was a problem hiding this comment.
Re-run this NB on the DL NB server, so that it can use the DESI 23.x kernel (this is important, because specific kernels usually have specific S/W installed)/
| @@ -16,7 +16,7 @@ | |||
| "outputs": [], | |||
| "source": [ | |||
| "__author__ = 'Ragadeepika Pucha <[email protected]>, Stephanie Juneau <[email protected]>'\n", | |||
| "__version__ = '20230824' \n", | |||
| "__version__ = '20230824' #yyyymmdd\n", | |||
There was a problem hiding this comment.
Update the version whenever you change and NB.
| @@ -1480,7 +1480,7 @@ | |||
| ], | |||
| "metadata": { | |||
| "kernelspec": { | |||
| "display_name": "Python 3", | |||
| "display_name": "Python 3 (ipykernel)", | |||
There was a problem hiding this comment.
Re-run on DL's NB server to use the DL Python 3 kernel.
| @@ -3342,7 +3342,7 @@ | |||
| ], | |||
| "metadata": { | |||
| "kernelspec": { | |||
| "display_name": "Python 3", | |||
| "display_name": "Python 3 (ipykernel)", | |||
| @@ -350,7 +350,7 @@ | |||
| "\n", | |||
| "The many S-PLUS photometric bands can be used to produce color-color diagrams that are useful for measuring properties such as the metallicity or surface gravity of a star.\n", | |||
| "\n", | |||
| "(g-F515) vs. (g-r) is sensitive to surface gravity and can be used to separate dwarf stars from giant stars. The main locus of points is the dwarfs will the red giant live in the upper right. [See Majewski et al. (2000)](http://adsabs.harvard.edu/abs/2000AJ....120.2550M) for more details on this method." | |||
| "(g-F515) vs. (g-r) is sensitive to surface gravity and can be used to separate dwarf stars from giant stars. The main focus of points is the dwarfs, while the red giant live in the upper right. [See Majewski et al. (2000)](http://adsabs.harvard.edu/abs/2000AJ....120.2550M) for more details on this method." | |||
There was a problem hiding this comment.
'locus' was correct, please change back. The sentence had typos though, and I think it should be "The main locus of points is the dwarfs, while the red giants live in the upper right."
| @@ -2277,7 +2277,7 @@ | |||
| "ax1 = fig.add_subplot(121)\n", | |||
| "ax2 = fig.add_subplot(122)\n", | |||
| "\n", | |||
| "# color-magnitude diagram (Hess diagram)\n", | |||
| "# color-color diagram\n", | |||
There was a problem hiding this comment.
"Hess diagram" could be put back with a link to the short wikipedia page: https://en.wikipedia.org/wiki/Hess_diagram
|
After discussion, @i-olin will create a new branch instead. Once the new branch is complete accounting for the changes requested here, and the new PR is merged, we will close this one. |
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Grammar and typo corrections.