Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace np.float() deprecated in newer numpy version with the built-i… #245

Merged
merged 2 commits into from
Aug 6, 2024
Merged

Replace np.float() deprecated in newer numpy version with the built-i… #245

merged 2 commits into from
Aug 6, 2024

Conversation

rnikutta
Copy link
Member

@rnikutta rnikutta commented Aug 2, 2024

…n float()

@rnikutta rnikutta requested a review from stephjuneau August 2, 2024 16:19
@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@rnikutta
Copy link
Member Author

rnikutta commented Aug 2, 2024

@stephjuneau the np.float() fix seems to be working fine. Can you please review and approve this PR?

@stephjuneau Review Notebook App
Copy link
Contributor

Looks good!

stephjuneau
stephjuneau approved these changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@stephjuneau stephjuneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the notebook!

@rnikutta rnikutta merged commit 28730bb into master Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephjuneau stephjuneau stephjuneau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rnikutta @stephjuneau