-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PGIR DR1 light curves #252
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
I will strongly suggest to please change the nbid to something else (0069 or higher) since @rnikutta and I agreed that nbid would be reserved to the legacy survey notebook that we are working on. That is already in the name of all tables and indices used by such nb in the database and in the tap_schema. |
Yes, please bump nbid up to 0069 @jacquesalice , thanks! |
Done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jacquesalice. I just finished running the notebook and didn't run into any issues. I caught a few spelling mistakes, but other than that, it looks good!
Thanks @bmerino95 ! I implemented all of your suggested changes. Can you please Approve the PR? We'll still wait to merge until the photometry table is done copying over |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Hi @bmerino95 can you please review this PGIR notebook? The pgir_dr1.photometry table is still being copied over to prod, so you'll have to set the profile to db01 for now (
qc.set_profile('db01')
). It should be complete in the next day or two, so we won't merge this PR until then