Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PGIR DR1 light curves #252

Merged
merged 13 commits into from
Oct 1, 2024
Merged

PGIR DR1 light curves #252

merged 13 commits into from
Oct 1, 2024

Conversation

jacquesalice
Copy link
Member

Hi @bmerino95 can you please review this PGIR notebook? The pgir_dr1.photometry table is still being copied over to prod, so you'll have to set the profile to db01 for now (qc.set_profile('db01')). It should be complete in the next day or two, so we won't merge this PR until then

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@kareninysimba
Copy link
Contributor

I will strongly suggest to please change the nbid to something else (0069 or higher) since @rnikutta and I agreed that nbid would be reserved to the legacy survey notebook that we are working on. That is already in the name of all tables and indices used by such nb in the database and in the tap_schema.
I will highly appreciate it.
Thanks!

@rnikutta
Copy link
Member

Yes, please bump nbid up to 0069 @jacquesalice , thanks!

@jacquesalice
Copy link
Member Author

I will strongly suggest to please change the nbid to something else (0069 or higher) since @rnikutta and I agreed that nbid would be reserved to the legacy survey notebook that we are working on. That is already in the name of all tables and indices used by such nb in the database and in the tap_schema. I will highly appreciate it. Thanks!

Done!

Copy link
Contributor

@bmerino95 bmerino95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jacquesalice. I just finished running the notebook and didn't run into any issues. I caught a few spelling mistakes, but other than that, it looks good!

@jacquesalice
Copy link
Member Author

Thanks @bmerino95 ! I implemented all of your suggested changes. Can you please Approve the PR?

We'll still wait to merge until the photometry table is done copying over

Copy link
Contributor

@bmerino95 bmerino95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jacquesalice jacquesalice merged commit 9f1cf65 into master Oct 1, 2024
@jacquesalice jacquesalice deleted the pgir_lightcurves branch October 1, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants