Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple fixes for airflow docs ingest #112

Closed
wants to merge 8 commits into from
Closed

Conversation

mpgreg
Copy link
Contributor

@mpgreg mpgreg commented Nov 13, 2023

Copy link
Collaborator

@pankajastro pankajastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I feel we should test this once in Asto just to avoid any error

airflow/include/tasks/split.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@sunank200 sunank200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the GitHub PR description for this, please?

I had two questions:

  • How does this change affect retrieval?
  • @vatsrahul1001 needs to test this change and validate that its improving the related documents before we merge this PR. Just blocking this PR until that is done.

@mpgreg mpgreg deleted the branch astronomer:main November 19, 2023 18:32
@mpgreg mpgreg closed this Nov 19, 2023
@mpgreg mpgreg deleted the main branch November 19, 2023 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants