-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(circleci): setup deploy-docs job #130
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with Cloudflare Pages
|
Lee-W
force-pushed
the
setup-gh-pages-deploy
branch
5 times, most recently
from
November 16, 2023 03:16
2d432f0
to
bd2b6e5
Compare
Lee-W
force-pushed
the
setup-gh-pages-deploy
branch
from
November 17, 2023 09:14
e55f7e7
to
981425d
Compare
https://astronomer.github.io/ask-astro/ it's here |
sunank200
approved these changes
Nov 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
But let's make sure that airflow docs are visible first as part of this PR: #131 before merging this.
This is still not visible correctly @Lee-W ? |
Lee-W
force-pushed
the
setup-gh-pages-deploy
branch
from
November 20, 2023 14:25
981425d
to
7ca054b
Compare
just rebased. once this is merged, the doc will be updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close: #122
I think the last step we need is
which might need @sunank200 's help on setting this up. (Scheduled messages with info and instructions for this setup on Slack)
ref: https://circleci.com/blog/deploying-documentation-to-github-pages-with-continuous-integration/